linux-kernel - Re: perf_counter: buffer overwrite problem for perf top command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090510062252.GB30778@elte.hu>
Date:	Sun, 10 May 2009 08:22:52 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Erdem Aktas <eaktas1@...il.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: perf_counter: buffer overwrite problem for perf top command


* Erdem Aktas <eaktas1@...il.com> wrote:

> Hi;
> There is a buffer overwrite problem in builtin-top.c line 526, When I
> tried to use ./perf top command, it was giving memory corruption
> problem. should not we use malloc(strlen(str)+1) ?

indeed, well spotted - we do an strcpy into that buffer so the \0 at 
the end of the string has to be allocated too.

I've applied it to tip:perfcounters/core and tip/master and pushed 
it out. Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/