linux-kernel - Re: [PATCH 1/5] Split wait_noreap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 May 2009 12:20:50 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Vitaly Mayatskikh <v.mayatskih@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Roland McGrath <roland@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] Split wait_noreap_copyout()

* Vitaly Mayatskikh <v.mayatskih@...il.com> wrote:

> -static int wait_noreap_copyout(struct wait_opts *wo, struct task_struct *p,
> -				pid_t pid, uid_t uid, int why, int status)
> +static int wait_copyout(struct wait_opts *wo, struct task_struct *p,
> +			pid_t pid, uid_t uid, int why, int status, int signal)

Nice cleanups. Would be nice to fix the naming here too while at it.

Right now it's two verbs and a straightforward reading of it suggest 
that we 'wait for some copyout to occur', which is nonsensical and 
confusing.

So please put the main action as the first verb (this is an internal 
symbol so no subsystem differentiator is needed). Something like:

  copy_wait_opts_to_user()

... and it becomes a whole lot easier to read. This matches the 
copy*to_user idioms we have elsewhere so it nicely wibes with the 
sound of those.

( Now repeat similar measures on the whole tree, a hundred thousand 
  times or so, and enforce it for all new patches, and we'd have
  crisp, consistent, highly readable and enjoyable kernel source ;-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/