linux-kernel - Re: [PATCH 1/2] CRED: Rename cred_exec_mutex to reflect that it's a guard against ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090511113356.GB4748@elte.hu>
Date:	Mon, 11 May 2009 13:33:56 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Roland McGrath <roland@...hat.com>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	David Howells <dhowells@...hat.com>, jmorris@...ei.org,
	chrisw@...s-sol.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, eparis@...hat.com,
	sds@...ho.nsa.gov
Subject: Re: [PATCH 1/2] CRED: Rename cred_exec_mutex to reflect that it's
	a guard against ptrace


* Roland McGrath <roland@...hat.com> wrote:

> > Hmm. Ingo's "rename ptrace_may_access => ptrace_access_check" conflicts
> > with my patch too.
> 
> Andrew seemed to want a different name choice too, so that will have to be
> resolved before we worry about patch conflicts.
> 
> > Andrew, Roland, I guess I should re-send
> > 	
> > 	ptrace-ptrace_attach-check-pf_kthread-exit_state-instead-of-mm.patch
> > 	ptrace-cleanup-check-set-of-pt_ptraced-during-attach.patch
> > 	ptrace-do-not-use-task_lock-for-attach.patch
> > 
> > patches?
> 
> I guess so too.  Your series of changes is more substantial and 
> potentially controversial or problematic than the various 
> renamings, so I think it makes sense to settle and merge the 
> renamings first.

yeah, cleanups first is generally the better strategy. Not only does 
it make reverts easier, it also makes it easier to review (and 
potentially fix) later patches.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/