linux-kernel - Re: [tip:perfcounters/core] perf_counter, x86: remove X86_FEATURE_ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090511123935.GA10722@erda.amd.com>
Date:	Mon, 11 May 2009 14:39:35 +0200
From:	Robert Richter <robert.richter@....com>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
CC:	Ingo Molnar <mingo@...e.hu>, mingo@...hat.com, hpa@...or.com,
	paulus@...ba.org, linux-kernel@...r.kernel.org,
	a.p.zijlstra@...llo.nl, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perfcounters/core] perf_counter, x86: remove
	X86_FEATURE_ARCH_PERFMON flag for AMD cpus

On 11.05.09 17:43:44, Jaswinder Singh Rajput wrote:
> On Sun, 2009-05-10 at 08:30 +0200, Ingo Molnar wrote:
> > * Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:
> > 
> > > > #define X86_FEATURE_ARCH_PERFMON (3*32+11) /* Intel Architectural PerfMon */
> > > > should be replaced by
> > > > #define X86_FEATURE_ARCH_PERFMON (3*32+11) /* Performace Monitor */
> > > > 
> > > > All x86 cpus which support performance monitor should set this feature.
> > > > 
> > > 
> > > Currently X86_FEATURE_ARCH_PERFMON is enabled for >= Intel Core2
> > > 
> > > But Performance monitor is almost supported by all Intel 
> > > processors. I am adding few MSRs list for reference to see 
> > > complete list please check arch/x86/kernel/cpu/cpu_debug.c
> > 
> > I think you are confusing two things:
> > 
> > - The 'architectural perfmon' CPU flag, enumerated in CPUID. (this 
> >   is a relatively new CPUID flag that only Intel CPUs at around 
> >   Core2 and later will report.)
> > 
> > - The concept of 'performance monitoring' - which has been present 
> >   in various x86 CPUs starting at the original Pentium (P5) 15 years 
> >   ago or so.
> > 
> 
> Here is the patch for review for ancient performance monitoring
> cpufeature, complete cpu_debug and cpu_feature patches are available
> at :
> http://git.kernel.org/?p=linux/kernel/git/jaswinder/linux-2.6-tip.git;a=summary
> 
> Subject: [PATCH] x86: Add cpufeature for ancient performance monitoring

Jaswinder,

which branch is this patch against? It is not tip/perfcounters/core
nor tip/master.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@....com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/