linux-kernel - Re: [FOR REVIEW, PATCH 2/2] introduce "struct wait_opts" to simplify do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 May 2009 14:43:14 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andy Whitcroft <apw@...onical.com>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	Roland McGrath <roland@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [FOR REVIEW, PATCH 2/2] introduce "struct wait_opts" to
	simplify do_wait() pathes


* Andy Whitcroft <apw@...onical.com> wrote:

> On Sat, May 09, 2009 at 06:15:06PM +0200, Oleg Nesterov wrote:
> > (add Andy)
> > 
> > On 05/07, Ingo Molnar wrote:
> > >
> > > * Oleg Nesterov <oleg@...hat.com> wrote:
> > >
> > > > On 05/06, Ingo Molnar wrote:
> > > > >
> > > > > One small nit with the definition above: when using vertical spacing
> > > > > (which really looks nice) we tend to put the asterix to the type
> > > > > itself, not to the variable. I.e.:
> > > > >
> > > > > 	enum pid_type		wtype;
> > > > > 	struct pid *		wpid;
> > > > > 	int			wflags;
> 
> My expectation would normally be that this would be written more as:
> 
>  	enum pid_type		wtype;
>  	struct pid		*wpid;
>  	int			wflags;

Correct - i was confused there.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/