linux-kernel - Re: [tip:x86/xen] x86: use flush_tlb_others to implement flush_tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090511131230.GA32693@elte.hu>
Date:	Mon, 11 May 2009 15:12:30 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	ian.campbell@...rix.com, Jeremy.Fitzhardinge@...rix.com,
	tglx@...utronix.de, Ian.Campbell@...citrix.com,
	xen-devel@...ts.xensource.com
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/xen] x86: use flush_tlb_others to implement
	flush_tlb_all, fix


* tip-bot for Ian Campbell <Ian.Campbell@...citrix.com> wrote:

> Commit-ID:  636afdbe85d50d9b88f5283b5e6d0f8518431aac
> Gitweb:     http://git.kernel.org/tip/636afdbe85d50d9b88f5283b5e6d0f8518431aac
> Author:     Ian Campbell <Ian.Campbell@...citrix.com>
> AuthorDate: Fri, 8 May 2009 16:52:07 +0100
> Committer:  Ingo Molnar <mingo@...e.hu>
> CommitDate: Mon, 11 May 2009 15:08:08 +0200
> 
> x86: use flush_tlb_others to implement flush_tlb_all, fix
> 
> "use the flush_tlb_others() call to implement flush_tlb_all()"
> causes:
>          BUG: spinlock bad magic on CPU#0, swapper/0
>           lock: c05b7588, .magic: 00000000, .owner: <none>/-1, .owner_cpu: 0
>          Pid: 0, comm: swapper Not tainted 2.6.30-rc3-x86_32p-xen0-tip-01797-g3db7847 #1054
>          Call Trace:
>           [<c023e656>] spin_bug+0x96/0xf0
>           [<c023e90f>] _raw_spin_lock+0x6f/0x150
> 
> It can be called before the core_initcalls are run. Explicitly call
> init_smp_flush early on.
> 
> Also there is no need for init_smp_flush to be __cpuinit.
> 
> [ Impact: fix boot crash/warning ]
> 
> Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
> Cc: Xen-devel <xen-devel@...ts.xensource.com>
> Acked-by: Jeremy Fitzhardinge <Jeremy.Fitzhardinge@...rix.com>
> LKML-Reference: <1241797927.15972.51.camel@...az.uk.xensource.com>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> 
> 
> ---
>  arch/x86/include/asm/tlbflush.h |    2 ++
>  arch/x86/mm/tlb.c               |    3 +--
>  init/main.c                     |    1 +
>  3 files changed, 4 insertions(+), 2 deletions(-)

which then does:

init/main.c:728: error: implicit declaration of function ‘init_smp_flush’

i've excluded tip:x86/xen from tip:master for now.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/