linux-kernel - Re: [PATCH 1/2] x86: Sanity check the e820 against the SRAT table using e820 map only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A08497C.8010203@kernel.org>
Date:	Mon, 11 May 2009 08:51:24 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Mel Gorman <mel@....ul.ie>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] x86: Sanity check the e820 against the SRAT table
 using e820 map only

Ingo Molnar wrote:
> * Yinghai Lu <yinghai@...nel.org> wrote:
> 
>> -	e820ram = max_pfn - absent_pages_in_range(0, max_pfn);
>> +	e820ram = max_pfn - (e820_hole_size(0, max_pfn<<PAGE_SHIFT)>>PAGE_SHIFT);
> 
> btw., it would be nice to have a debug check that prints a warning 
> if the SRAT does not cover all RAM, or if it covers RAM that is not 
> present in the e820 map. Such a warning might alert us to double 
> check all the PXM settings in the SRAT and could uncover more quirks 
> like the above ...

we trust e820 than SRAT mem entries.

so early_node_map already are result of in e820 range AND srat.  (the range in SRAT that is not in e820 is dumped)

just check srat table (without AND) with e820 will have some confusing. because SRAT would cover the hole below 4g that is not in E820.

YH


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/