linux-kernel - Re: Quick question about libata and hdparm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A086FCF.5090907@garzik.org>
Date:	Mon, 11 May 2009 14:34:55 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
CC:	Rogério Brito <rbrito@....usp.br>,
	Michael Tokarev <mjt@....msk.ru>, Mark Lord <lkml@....ca>,
	linux-kernel@...r.kernel.org, Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: Quick question about libata and hdparm

Bartlomiej Zolnierkiewicz wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> Subject: [PATCH] pata_pdc202xx_old: fix UDMA33 handling
> 
> The original driver doesn't use 66 MHz clock for UDMA33.
> 
> [ The alternative solution would be to adjust UDMA33 timings
>   for 66 MHz clock but I think that it is safer to stick with
>   old & tested behavior for now. ]
> 
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> ---
>  drivers/ata/pata_pdc202xx_old.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Index: b/drivers/ata/pata_pdc202xx_old.c
> ===================================================================
> --- a/drivers/ata/pata_pdc202xx_old.c
> +++ b/drivers/ata/pata_pdc202xx_old.c
> @@ -2,7 +2,7 @@
>   * pata_pdc202xx_old.c 	- Promise PDC202xx PATA for new ATA layer
>   *			  (C) 2005 Red Hat Inc
>   *			  Alan Cox <alan@...rguk.ukuu.org.uk>
> - *			  (C) 2007 Bartlomiej Zolnierkiewicz
> + *			  (C) 2007,2009 Bartlomiej Zolnierkiewicz
>   *
>   * Based in part on linux/drivers/ide/pci/pdc202xx_old.c
>   *
> @@ -158,7 +158,7 @@ static void pdc2026x_bmdma_start(struct 
>  	u32 len;
>  
>  	/* Check we keep host level locking here */
> -	if (adev->dma_mode >= XFER_UDMA_2)
> +	if (adev->dma_mode > XFER_UDMA_2)
>  		iowrite8(ioread8(clock) | sel66, clock);
>  	else
>  		iowrite8(ioread8(clock) & ~sel66, clock);
> @@ -212,7 +212,7 @@ static void pdc2026x_bmdma_stop(struct a
>  		iowrite8(ioread8(clock) & ~sel66, clock);
>  	}
>  	/* Flip back to 33Mhz for PIO */
> -	if (adev->dma_mode >= XFER_UDMA_2)
> +	if (adev->dma_mode > XFER_UDMA_2)
>  		iowrite8(ioread8(clock) & ~sel66, clock);


applied

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/