linux-kernel - Re: [PATCH 1/4] kernel: constructor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 May 2009 20:54:24 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>
Cc:	Américo Wang <xiyou.wangcong@...il.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Huang Ying <ying.huang@...el.com>, Li Wei <W.Li@....COM>,
	Michael Ellerman <michaele@....ibm.com>,
	Ingo Molnar <mingo@...e.hu>,
	Heiko Carstens <heicars2@...ux.vnet.ibm.com>,
	Martin Schwidefsky <mschwid2@...ux.vnet.ibm.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Jeff Dike <jdike@...toit.com>
Subject: Re: [PATCH 1/4] kernel: constructor support

On Mon, May 11, 2009 at 10:43:34AM +0200, Peter Oberparleiter wrote:
> Américo Wang wrote:
> >On Fri, May 08, 2009 at 05:44:09PM +0200, Peter Oberparleiter wrote:
> >>From: Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>
> >>Index: linux-2.6.30-rc4/init/main.c
> >>===================================================================
> >>--- linux-2.6.30-rc4.orig/init/main.c
> >>+++ linux-2.6.30-rc4/init/main.c
> >>@@ -700,6 +700,18 @@ asmlinkage void __init start_kernel(void
> >>	rest_init();
> >>}
> >>
> >>+/* Call all constructor functions linked into the kernel. */
> >>+static void __init do_ctors(void)
> >>+{
> >>+#ifdef CONFIG_CONSTRUCTORS
> >>+	extern ctor_fn_t __ctors_start[], __ctors_end[];
> >
> >
> >I would like these to be globally decleared, since they are.
> 
> Ok, I will move the __ctors_* declarations to include/linux/ínit.h

include/asm-generic/sections.h please.
And please add a comment too.

That the other entries in the same file lacks a comment is not
the example to follow.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/