linux-kernel - Re: [RFT] rtl8187: use DMA-aware buffers with usb_control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ace41890905111523n7a924cd1x7cf4741e85153bdd@mail.gmail.com>
Date:	Mon, 11 May 2009 23:23:46 +0100
From:	Hin-Tak Leung <hintak.leung@...il.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>, Greg KH <greg@...ah.com>,
	Eric Valette <eric.valette@...e.fr>,
	linux-wireless@...r.kernel.org,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [RFT] rtl8187: use DMA-aware buffers with usb_control_msg

On Mon, May 11, 2009 at 2:20 PM, John W. Linville
<linville@...driver.com> wrote:
> On Sat, May 09, 2009 at 04:24:21PM -0500, Larry Finger wrote:
>> John W. Linville wrote:
>> >
>> > Yeah, I don't like the original version either.  Even if the kmalloc's
>> > aren't a big performance hit, the failure path sucks.  I've included a
>> > new version below, but unfortunately I haven't had a chance to test it.
>> > Please give it a try if you get a chance?
>>
>> This one tests just fine here running on the latest pull of wireless testing
>> (v2.6.30-rc4-22732-gd879ac6). I think there is a leak of priv->io_dmabuf when
>> the driver is unloaded, and kfree(priv->io_dmabuf) should be added to
>> rtl8187_disconnect(). Otherwise ACK.
>
> Doh!
>
> ---
>
> From dbc8e19329b52c53832cbb03eea76646e44aab07 Mon Sep 17 00:00:00 2001
> From: John W. Linville <linville@...driver.com>
> Date: Wed, 6 May 2009 13:57:27 -0400
> Subject: [PATCH] rtl8187: use DMA-aware buffers with usb_control_msg
>
> Signed-off-by: John W. Linville <linville@...driver.com>

This looks so much cleaner. ACK - I see you already checked this in to
wireless-testing. Tried to give it a go just now, but got bitten by
the wext key management change, I think.

Hin-Tak
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/