linux-kernel - Re: [PATCH] cred: #include init.h in cred.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.0905120831560.3090@tundra.namei.org>
Date:	Tue, 12 May 2009 08:32:31 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Alexey Dobriyan <adobriyan@...il.com>,
	linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] cred: #include init.h in cred.h

On Mon, 11 May 2009, Andrew Morton wrote:

> On Sat, 9 May 2009 07:36:52 +0400
> Alexey Dobriyan <adobriyan@...il.com> wrote:
> 
> > linux/cred.h can't be included as first header (alphabetical order)
> > because it uses __init which is enough to break compilation on some
> > archs.
> > 
> 
> hm, OK, not a lot of detail there though.
> 
> > 
> > --- a/include/linux/cred.h
> > +++ b/include/linux/cred.h
> > @@ -13,6 +13,7 @@
> >  #define _LINUX_CRED_H
> >  
> >  #include <linux/capability.h>
> > +#include <linux/init.h>
> >  #include <linux/key.h>
> >  #include <asm/atomic.h>
> 
> I assume that this is needed in 2.6.30?
> 

I can see it's in -mm, so might as well go to Linus via there.

Acked-by: James Morris <jmorris@...ei.org>


-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/