linux-kernel - Re: [v3][PATCH 5/5] Merge code for singleandmultiple-instancemounts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A08AAE0.6030300@zytor.com>
Date:	Mon, 11 May 2009 15:46:56 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	"Serge E. Hallyn" <serue@...ibm.com>
CC:	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>,
	Marc Dionne <marc.c.dionne@...il.com>,
	Eric Paris <eparis@...hat.com>,
	Eric Paris <eparis@...isplace.org>,
	Christoph Hellwig <hch@....de>, Andrew Morton <akpm@...l.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>, sukadev@...ibm.com,
	linux-kernel@...r.kernel.org, jbacik@...hat.com
Subject: Re: [v3][PATCH 5/5] Merge code for singleandmultiple-instancemounts

Serge E. Hallyn wrote:
> Quoting Sukadev Bhattiprolu (sukadev@...ux.vnet.ibm.com):
> ...
> 
>> >From 2f7746f4df78ff57125c4714f0cd64e739ccf804 Mon Sep 17 00:00:00 2001
>> From: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
>> Date: Mon, 11 May 2009 13:11:11 -0700
>> Subject: [PATCH] devpts: Correctly set default options
>>
>> devpts_get_sb() calls memset(0) to clear mount options and calls
>> parse_mount_options() if user specified any mount options. The memset(0) is
>> bogus since the 'mode' and 'ptmxmode' options are non-zero by default.
>> parse_mount_options() restores options to default anyway and can properly deal
>> with NULL mount options.
>>
>> So in devpts_get_sb() remove memset(0) and call parse_mount_options() even for
>> NULL mount options.
>>
>> Bug reported by Eric Paris: http://lkml.org/lkml/2009/5/7/448.
> 
> Would you almost say... Reported-by: ?  :)
>> Signed-off-by: Sukadev Bhattiprolu (sukadev@...ibm.com)
> 
> Looks good.
> 
> Acked-by: Serge Hallyn <serue@...ibm.com>
> 

Reviewed-by: H. Peter Anvin <hpa@...or.com>

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/