| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1242082784.27353.13.camel@mulgrave.int.hansenpartnership.com> Date: Mon, 11 May 2009 22:59:44 +0000 From: James Bottomley <James.Bottomley@...senPartnership.com> To: Arnd Bergmann <arnd@...db.de> Cc: linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org Subject: Re: [PATCH] scsi: libsas depends on HAS_DMA On Mon, 2009-05-11 at 22:50 +0000, James Bottomley wrote: > On Mon, 2009-05-11 at 22:40 +0000, Arnd Bergmann wrote: > > libsas uses the DMA mapping API, so it cannot be > > built on architectures that don't support DMA. > > > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > > --- > > drivers/scsi/libsas/Kconfig | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/scsi/libsas/Kconfig b/drivers/scsi/libsas/Kconfig > > index 18f33cd..59e00fa 100644 > > --- a/drivers/scsi/libsas/Kconfig > > +++ b/drivers/scsi/libsas/Kconfig > > @@ -24,7 +24,7 @@ > > > > config SCSI_SAS_LIBSAS > > tristate "SAS Domain Transport Attributes" > > - depends on SCSI > > + depends on SCSI && HAS_DMA > > Our unfortunate Kconfig system can cause problems if you do this: > SCSI_SAS_LIBSAS is used as a select for drivers that need it, so either > they'd need to select this themselves, or you need some other solution. Actually, looking at this further, the problem is only in the ata compatibility layer because of the way libata does dma mapping on behalf of drivers, so the solution below (just disable SATA support if HAS_DMA isn't defined) will work without requiring select dependency modification. James --- diff --git a/drivers/scsi/libsas/Kconfig b/drivers/scsi/libsas/Kconfig index 18f33cd..f462a0e 100644 --- a/drivers/scsi/libsas/Kconfig +++ b/drivers/scsi/libsas/Kconfig @@ -33,6 +33,7 @@ config SCSI_SAS_LIBSAS config SCSI_SAS_ATA bool "ATA support for libsas (requires libata)" depends on SCSI_SAS_LIBSAS + depends on HAS_DMA depends on ATA = y || ATA = SCSI_SAS_LIBSAS help Builds in ATA support into libsas. Will necessitate -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists