linux-kernel - Re: [PATCH 1/3] IMA: use current_cred() instead of current->cred

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1242083782.4131.2.camel@dyn9002018117.watson.ibm.com>
Date:	Mon, 11 May 2009 19:16:22 -0400
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	Eric Paris <eparis@...hat.com>
Cc:	linux-kernel@...r.kernel.org, jmorris@...ei.org
Subject: Re: [PATCH 1/3] IMA: use current_cred() instead of current->cred

On Mon, 2009-05-11 at 13:59 -0400, Eric Paris wrote:
> Proper invocation of the current credentials is to use current_cred() not
> current->cred.  This patches makes IMA use the new method.
> 
> Signed-off-by: Eric Paris <eparis@...hat.com>
acked-by: Mimi Zohar <zohar@...ibm.com>

> ---
> 
>  security/integrity/ima/ima_audit.c |    2 +-
>  security/integrity/ima/ima_main.c  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/security/integrity/ima/ima_audit.c b/security/integrity/ima/ima_audit.c
> index b628eea..ff513ff 100644
> --- a/security/integrity/ima/ima_audit.c
> +++ b/security/integrity/ima/ima_audit.c
> @@ -41,7 +41,7 @@ void integrity_audit_msg(int audit_msgno, struct inode *inode,
> 
>  	ab = audit_log_start(current->audit_context, GFP_KERNEL, audit_msgno);
>  	audit_log_format(ab, "integrity: pid=%d uid=%u auid=%u ses=%u",
> -			 current->pid, current->cred->uid,
> +			 current->pid, current_cred()->uid,
>  			 audit_get_loginuid(current),
>  			 audit_get_sessionid(current));
>  	audit_log_task_context(ab);
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 122f17f..cdae13c 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -184,7 +184,7 @@ int ima_path_check(struct path *path, int mask)
>  		struct dentry *dentry = dget(path->dentry);
>  		struct vfsmount *mnt = mntget(path->mnt);
> 
> -		file = dentry_open(dentry, mnt, O_RDONLY, current->cred);
> +		file = dentry_open(dentry, mnt, O_RDONLY, current_cred());
>  		rc = get_path_measurement(iint, file, dentry->d_name.name);
>  	}
>  out:
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/