linux-kernel - Re: [PATCH v2] x86: fix ktermios-termio conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 May 2009 11:26:01 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	Arnd Bergmann <arnd@...db.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Remis Lima Baima <remis.developer@...glemail.com>
Subject: Re: [PATCH v2] x86: fix ktermios-termio conversion


* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> > hm, on x86 you could use get_user_try / get_user_ex() / 
> > get_user_catch() approach to linearize the dependencies and 
> > reduce register pressure.
> 
> It used *once*, in a path that is never executed except by some 
> ancient binaries. It isn't worth the effort.

i know, and i tested the patch so i know what effects it has.

I never made any argument about inlining, it's obviously correct to 
have a use-once function inline.

My argument was very simple: the patch causes +150 bytes of bloat. 
The try/ex/catch method can help reduce register pressure and can 
reducethe size of code quite visibly.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/