linux-kernel - Re: [PATCH] x86: introduce io_apic_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090512103236.GC11714@elte.hu>
Date:	Tue, 12 May 2009 12:32:36 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Len Brown <lenb@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-pci@...r.kernel.org,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH] x86: introduce io_apic_irq_attr -v2


* Yinghai Lu <yinghai@...nel.org> wrote:

> +				irq_attr->ioapic     = apic;
> +				irq_attr->ioapic_pin = mp_irqs[i].dstirq;
> +				irq_attr->trigger    = irq_trigger(i);
> +				irq_attr->polarity   = irq_polarity(i);

> +				irq_attr->ioapic     = apic;
> +				irq_attr->ioapic_pin = mp_irqs[i].dstirq;
> +				irq_attr->trigger    = irq_trigger(i);
> +				irq_attr->polarity   = irq_polarity(i);

Shouldnt this be factored out ino a helper function?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/