linux-kernel - Re: [PATCH] range-bw: Another I/O scheduling policy of dm-ioband supporting the predicable I/O bandwidth (range bandwidth)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090512.203014.71110404.ryov@valinux.co.jp>
Date:	Tue, 12 May 2009 20:30:14 +0900 (JST)
From:	Ryo Tsuruta <ryov@...inux.co.jp>
To:	baramsori72@...il.com
Cc:	righi.andrea@...il.com, menage@...gle.com,
	balbir@...ux.vnet.ibm.com, guijianfeng@...fujitsu.com,
	kamezawa.hiroyu@...fujitsu.com, agk@...rceware.org,
	akpm@...ux-foundation.org, axboe@...nel.dk, chlunde@...g.uio.no,
	dave@...ux.vnet.ibm.com, dpshah@...gle.com, eric.rannaud@...il.com,
	fernando@....ntt.co.jp, taka@...inux.co.jp, lizf@...fujitsu.com,
	matt@...ehost.com, dradford@...ehost.com, ngupta@...gle.com,
	randy.dunlap@...cle.com, roberto@...it.it, s-uchida@...jp.nec.com,
	subrata@...ux.vnet.ibm.com, yoshikawa.takuya@....ntt.co.jp,
	nauman@...gle.com, fchecconi@...il.com, paolo.valente@...more.it,
	containers@...ts.linux-foundation.org,
	linux-kernel@...r.kernel.org, corsetproject@...glegroups.com
Subject: Re: [PATCH] range-bw: Another I/O scheduling policy of dm-ioband
 supporting the predicable I/O bandwidth (range bandwidth)

Hi Dong-Jae,

From: Dong-Jae Kang <baramsori72@...il.com>
Subject: Re: [PATCH] range-bw: Another I/O scheduling policy of dm-ioband supporting the predicable I/O bandwidth (range bandwidth)
Date: Wed, 6 May 2009 09:35:03 +0900

> 2009/5/5 Ryo Tsuruta <ryov@...inux.co.jp>:
> > Hi Dong-Jae
> >
> > From: Dong-Jae Kang <baramsori72@...il.com>
> > Subject: Re: [PATCH] range-bw: Another I/O scheduling policy of dm-ioband supporting the predicable I/O bandwidth (range bandwidth)
> > Date: Mon, 4 May 2009 20:23:04 +0900
> >
> >> Hi, Ryo
> >>
> >> I released bug-fixed range-bw(V1) controller several minutes ago
> >>
> >> Although several WARNINGs of checkpatch are remained,
> >> but patch file was strictly checked by checkpatch.pl
> >> It was very time-consuming job :)
> >> Thank you for your advice
> >>
> >> >>
> >> >> > I used fio 1.22. The below is a script which I actually ran.
> >> >> >
> >> >> >  #!/bin/sh
> >> >> >  dev1=/dev/sdb4 # SATA disk
> >> >> >  echo "0 $(sudo blockdev --getsize $dev1) ioband $dev1 share2 0 0
> >> >> >    cgroup range-bw 0" | sudo dmsetup create ioband1
> >> >> >
> >> >> >  arg="--time_based --runtime=10 --ioengine=libaio --iodepth=50 \
> >> >> >       --direct=1 --norandommap"
> >> >> >
> >> >> >  dmsetup message ioband1 0 attach 2
> >> >> >  dmsetup message ioband1 0 attach 3
> >> >> >  dmsetup message ioband1 0 min-bw 2:100
> >> >> >  dmsetup message ioband1 0 max-bw 2:100
> >> >> >  dmsetup message ioband1 0 min-bw 3:200
> >> >> >  dmsetup message ioband1 0 max-bw 3:200
> >> >>
> >> >> I recommend it is better to use different value in min-bw and max-bw
> >> >> because its concept is to support range-bw with the minimum
> >> >> guaranteeing and maximum limitation.
> >> >> exampe - min-bw : 1024 / max-bw : 3072
> >> >>
> >> >> >  echo $$ > /cgroup/grp1/tasks
> >> >> >  fio $arg --rw=randread --name=grp1 --filename=/dev/mapper/ioband1 \
> >> >> >          --output=r2-1.log &
> >> >> >  echo $$ > /cgroup/grp2/tasks
> >> >> >  fio $arg --rw=randread --name=grp2 --filename=/dev/mapper/ioband1 \
> >> >> >          --output=r2-2.log &
> >> >> >  wait
> >>
> >> after bug-fix,I evaluated range-bw according to your configuration and
> >> test environment
> >> the result is in new relesed range-bw mail, [PATCH 0/2]
> >> and more detailed documentation is also available and it can be
> >> referred in [PATCH 1/2]
> >>
> >> Ryo,
> >> can you check the result ?

I did the same test as before and got the results as expected.

               cgroup1    cgroup2
  min:max-bw    0:100      0:200
  -------------------------------------
  read          100         197
  write         103         198 [KB/s]

I got errors while applying your patch, some lines are wrapped with
carriage returns.

    +extern int policy_range_bw_init(struct ioband_device *dp, int argc,
 >> char **argv);

Thanks,
Ryo Tsuruta
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/