linux-kernel - Re: [PATCH] securityfs: securityfs_remove should handle IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.00.0905121135110.4463@tundra.namei.org>
Date:	Tue, 12 May 2009 11:35:23 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Eric Paris <eparis@...hat.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] securityfs: securityfs_remove should handle IS_ERR
 pointers

On Mon, 11 May 2009, Eric Paris wrote:

> Both of the securityfs users (TPM and IMA) can call securityfs_remove and pass
> an IS_ERR(dentry) in their failure paths.  This patch handles those rather
> than panicing when it tries to start deferencing some negative memory.
> 
> Signed-off-by: Eric Paris <eparis@...hat.com>

Applied to 
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

> ---
> 
>  security/inode.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/security/inode.c b/security/inode.c
> index f3b91bf..f7496c6 100644
> --- a/security/inode.c
> +++ b/security/inode.c
> @@ -287,7 +287,7 @@ void securityfs_remove(struct dentry *dentry)
>  {
>  	struct dentry *parent;
>  
> -	if (!dentry)
> +	if (!dentry || IS_ERR(dentry))
>  		return;
>  
>  	parent = dentry->d_parent;
> 

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/