linux-kernel - Re: [PATCH] ehca: remove driver_data direct access of struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OF8BA31CF1.C84202F8-ONC12575B4.004501A2-C12575B4.004599CE@de.ibm.com>
Date:	Tue, 12 May 2009 14:40:13 +0200
From:	Hoang-Nam Nguyen <HNGUYEN@...ibm.com>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	general@...ts.openfabrics.org, lkml <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>
Subject: Re: [PATCH] ehca: remove driver_data direct access of struct device

Hi,
Thanks for this patch. But I've to NACK because
1) Greg KH has already done a similar patch in his tree.
See http://lists.openfabrics.org/pipermail/general/2009-May/059442.html
2) Your patch is incomplete

Regards
Nam

Roel Kluin <roel.kluin@...il.com> wrote on 11.05.2009 22:25:07:

> From:
>
> Roel Kluin <roel.kluin@...il.com>
>
> To:
>
> Hoang-Nam Nguyen/Germany/IBM@...DE
>
> Cc:
>
> general@...ts.openfabrics.org, lkml <linux-kernel@...r.kernel.org>:
>
> Date:
>
> 11.05.2009 22:25
>
> Subject:
>
> [PATCH] ehca: remove driver_data direct access of struct device
>
> To avoid direct access to the driver_data pointer in struct device, the
> functions dev_get_drvdata() and dev_set_drvdata() should be used.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/drivers/infiniband/hw/ehca/ehca_main.c b/drivers/
> infiniband/hw/ehca/ehca_main.c
> index 368311c..5acfb4c 100644
> --- a/drivers/infiniband/hw/ehca/ehca_main.c
> +++ b/drivers/infiniband/hw/ehca/ehca_main.c
> @@ -749,7 +749,7 @@ static int __devinit ehca_probe(struct of_device
*dev,
>
>     shca->ofdev = dev;
>     shca->ipz_hca_handle.handle = *handle;
> -   dev->dev.driver_data = shca;
> +   dev_set_drvdata(&dev->dev, shca);
>
>     ret = ehca_sense_attributes(shca);
>     if (ret < 0) {
> @@ -878,7 +878,7 @@ probe1:
>
>  static int __devexit ehca_remove(struct of_device *dev)
>  {
> -   struct ehca_shca *shca = dev->dev.driver_data;
> +   struct ehca_shca *shca = dev_get_drvdata(&dev->dev);
>     unsigned long flags;
>     int ret;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/