linux-kernel - Re: [tip:irq/numa] x86: read apic ID in the !acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090512145808.GA20587@elte.hu>
Date:	Tue, 12 May 2009 16:58:08 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	yinghai@...nel.org, tglx@...utronix.de, eswierk@...stanetworks.com,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:irq/numa] x86: read apic ID in the !acpi_lapic case


* Cyrill Gorcunov <gorcunov@...il.com> wrote:

> [Ingo Molnar - Tue, May 12, 2009 at 01:22:05PM +0200]
> | 
> | this build bug is still unfixed:
> | 
> | drivers/pci/hotplug/ibmphp_core.c:165: error: expected identifier before ‘&’ token
> | drivers/pci/hotplug/ibmphp_core.c:166: error: too few arguments to function ‘IO_APIC_get_PCI_irq_vector’
> | 
> | 	Ingo
> | 
> 
> Grrr... this line looks really suspicious inideed
> 
> 			for (i = 0; i < 4; i++)
> 				(*cur_slot)->irq[i] = IO_APIC_get_PCI_irq_vector((int) (*cur_slot)->bus,
> --->						(int) (*cur_slot)->device, i.
> 						&ioapic, &ioapic_pin,
> 						&triggering, &polarity);
> 
> but it's _not_ 'cause of this commit, since
> we didn't even touch this file :) The point
> symbol should be changed to comma. Just a
> misprint I believe. Appened patch should do
> the trick.

Yinghai touched it:

e20c06f: x86/pci: add 4 more return parameters to IO_APIC_get_PCI_irq_vector()

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/