linux-kernel - Re: [PATCH 0/2] swim3: use blk_end_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A09FF0A.9030202@kernel.org>
Date:	Wed, 13 May 2009 07:58:18 +0900
From:	Tejun Heo <tj@...nel.org>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
CC:	jens.axboe@...cle.com, linux-kernel@...r.kernel.org,
	benh@...nel.crashing.org
Subject: Re: [PATCH 0/2] swim3: use blk_end_request_all()

Hello,

FUJITA Tomonori wrote:
>> It won't be freed.  The current segment will be failed and the next
>> segment of the request will be tried on the next iteration, which was
>> the original behavior.  ie. it always fails requests
>> segment-by-segment and hitting max retry count doesn't fail the whole
>> request.
> 
> Ah, I see. Thanks, then the current code is fine.
> 
> Well, it might be better to update some of the description of
> blk_update_request, e.g., "the special helper function is only for
> request stacking drivers".

Maybe but it encapsulates request details pretty well, so I wouldn't
really mind if it's used for other purposes (e.g. delaying actual
completion to ease internal bookkeeping).

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/