linux-kernel - Re: [PATCH] 8250: Don't restore NS16550 mode when console suspend is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090513094409.50c2409f@lxorguk.ukuu.org.uk>
Date:	Wed, 13 May 2009 09:44:09 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	dsaxena@...xity.net
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 8250: Don't restore NS16550 mode when console suspend
 is disabled

> > Surely if my console is at 230Kbits/sec then resuming it at a totally
> > different speed is going to break things for people even if it happens to
> > help XO debug ?
> 
> The console is not in high speed mode when we suspend. The original 
> commit (b5b82df6) just assumes that if it is a NATSEMI device, we 
> should set it to high speed mode at resume w/o checking if that 
> was the mode we were in when we suspended.

Then hard coding is no improvement either. It needs to restore the mode
that was present at suspend.

I'll update the 8250 Maintainers entry I suppose, I seem to have been
landed it as part of tty 8)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/