linux-kernel - Re: [Announce] 2.6.29.3-rt12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1242210288.26820.18.camel@twins>
Date:	Wed, 13 May 2009 12:24:48 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Hugo Vincent <hugo.vincent@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	rt-users <linux-rt-users@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Steven Rostedt <rostedt@...dmis.org>,
	Carsten Emde <ce@...g.ch>,
	Clark Williams <williams@...hat.com>,
	Frank Rowand <frank.rowand@...sony.com>,
	Robin Gareus <robin@...eus.org>,
	Gregory Haskins <ghaskins@...ell.com>,
	Philippe Reynes <philippe.reynes@...smpp.fr>,
	Fernando Lopez-Lezcano <nando@...ma.stanford.edu>,
	Will Schmidt <will_schmidt@...t.ibm.com>,
	Darren Hart <dvhltc@...ibm.com>, Jan Blunck <jblunck@...e.de>,
	Sven-Thorsten Dietrich <sdietrich@...ell.com>
Subject: Re: [Announce] 2.6.29.3-rt12

On Wed, 2009-05-13 at 12:19 +0200, Thomas Gleixner wrote:
> On Wed, 13 May 2009, Hugo Vincent wrote:
> > This patch resulted in a broken build for me, until I did this:
> > 
> > --- a/patch-2.6.29.3-rt12
> > +++ b/patch-2.6.29.3-rt12
> > @@ -121754,7 +121754,7 @@ Index: linux-2.6-tip/kernel/sched.c
> >   }
> > 
> >   /*
> > -@@ -2801,6 +3177,15 @@ static void update_cpu_load(struct rq *t
> > +@@ -2801,6 +3177,17 @@ static void update_cpu_load(struct rq *t
> >   			new_load += scale-1;
> >   		this_rq->cpu_load[i] = (old_load*(scale-1) + new_load) >> i;
> >   	}
> > @@ -121765,8 +121765,10 @@ Index: linux-2.6-tip/kernel/sched.c
> >  +	this_rq->calc_load_update += LOAD_FREQ;
> >  +	calc_load_account_active(this_rq);
> >  +
> > ++#ifdef CONFIG_SMP
> >  +	if (this_rq->cpu == calc_load_cpu)
> >  +		calc_global_load();
> > ++#endif
> >   }
> 
> Darn. the patch is halfways right. the #ifdef needs to be only around
> the if() line. Otherwise your /proc/loadavg values will never be
> updated. I'll push out -rt13 with the proper fix..

if (cpu_of(this_rq) == calc_load_cpu)

to reduce if-deffery
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/