linux-kernel - Re: [tip:irq/numa] x86: read apic ID in the !acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090513131405.GB21052@elte.hu>
Date:	Wed, 13 May 2009 15:14:05 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Cyrill Gorcunov <gorcunov@...il.com>, mingo@...hat.com,
	hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	eswierk@...stanetworks.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:irq/numa] x86: read apic ID in the !acpi_lapic case


* Yinghai Lu <yinghai@...nel.org> wrote:

> -	return hard_smp_processor_id() >> index_msb;
> +	return initial_apic_id >> index_msb;

> -	unsigned apicid = hard_smp_processor_id();
> +	unsigned apicid = cpu_has_apic ? hard_smp_processor_id() : c->apicid;

> -	int apicid = hard_smp_processor_id();
> +	int apicid = cpu_has_apic ? hard_smp_processor_id() : c->apicid;

Doesnt such a pattern call for the pushing of that distinction into 
hard_smp_processor_id() instead? (after a careful review of all 
hard_smp_processor_id() call-sites)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/