linux-kernel - Re: [PATCH] usb-serial: ftdi: don't dereference NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090513144159.GI32424@buzzloop.caiaq.de>
Date:	Wed, 13 May 2009 16:41:59 +0200
From:	Daniel Mack <daniel@...aq.de>
To:	Greg KH <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alan Stern <stern@...land.harvard.edu>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] usb-serial: ftdi: don't dereference NULL pointer

On Wed, May 13, 2009 at 07:35:36AM -0700, Greg KH wrote:
> On Wed, May 13, 2009 at 01:21:43PM +0200, Daniel Mack wrote:
> > The FTDI USB serial driver dereferences its priv structure in
> > ftdi_close() without checking for NULL pointer conditions, see the Oops
> > attached.
> 
> Hm, I think this was already resolved with Alan's patch that went in
> right after 2.6.30-rc5 came out. 

That was a similiar issue, yes. But it occured under different
circumstances, not under the condition I described.

> Can you check Linus's current tree to
> see if we still need this patch or not?

Is is needed, yes. I'm working on Linus' git as of this morning, so I'm
cutting edge mainline and can still perfectly reproduce the problem.

Not anymore with my patch, though.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/