linux-kernel - Re: [Sdhci-devel] Ricoh R5C822 and QUIRK_FORCE_DMA

Open Source and information security mailing list archives

Message-ID: <4A0B0CE1.3060309@damore.org>
Date:	Wed, 13 May 2009 11:09:37 -0700
From:	Garrett D'Amore <garrett@...ore.org>
To:	Pierre Ossman <pierre@...man.eu>
CC:	Tobias Diedrich <ranma+kernel@...edrich.de>,
	SDHCI development <sdhci-devel@...ts.ossman.eu>,
	linux-kernel@...r.kernel.org
Subject: Re: [Sdhci-devel] Ricoh R5C822 and QUIRK_FORCE_DMA

I know that we've run into some bizarre behavior with Ricoh controllers 
and DMA in the Solaris implementation of sdhost.  Specifically, what we 
ran into was problems with DMA across certain alignment boundaries.  It 
seems that when a DMA operation is not aligned on a 512 boundary, or 
does something less than a 512 byte transfer, it has trouble.

In the Solaris driver, I just allocate a big 64k page-aligned chunk for 
DMA, and use bcopy to/from that.  Frankly, bcopy is fast enough, that it 
makes little performance difference.  Plus, it means that I can use a 
larger interrupt threshold than 4K, allowing me to skip the 
scatter/gather overhead... I suspect that this negates the cost of the 
bcopy.

After doing this, the Lenovo and Toshiba laptops that I've had access to 
work well.

    - Garrett

Pierre Ossman wrote:
> (cc:ing sdhci-devel)
>
> On Fri, 1 May 2009 00:45:24 +0200
> Tobias Diedrich <ranma+kernel@...edrich.de> wrote:
>
>   
>> Do you know any controller bugs for this revision which may be the
>> reason for not advertising DMA capability?
>> I haven't done any big tests yet, but at first glance it seems to
>> read/write the card just fine.
>>
>>     
>
> Might be a system problem so it's Lenovo that disabled it. You're the
> first report I've seen on this since the DMA logic was reworked so that
> DMA didn't have to be forced for most cases.
>
> Is there anyone else reading this that are having DMA problems?
>
> Rgds
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> sdhci-devel mailing list
> sdhci-devel@...ts.ossman.eu
> http://list.drzeus.cx/mailman/listinfo/sdhci-devel
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives