linux-kernel - Re: [RFC][PATCH -tip] x86: audit.c remove unnecessary global arraysn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1242244159.3364.5.camel@localhost.localdomain>
Date:	Thu, 14 May 2009 01:19:18 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Ingo Molnar <mingo@...e.hu>, Al Viro <viro@...iv.linux.org.uk>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC][PATCH -tip] x86: audit.c remove unnecessary global
 arraysn

On Wed, 2009-05-13 at 21:42 +0200, Thomas Gleixner wrote:
> On Thu, 14 May 2009, Jaswinder Singh Rajput wrote:
>  
> > ia32_dir_class[], ia32_write_class[], ia32_read_class[], ia32_chattr_class[]
> > and ia32_signal_class[] are used only by arch/x86/kernel/audit_64.c
> > which can be replace by local variables:
> > 
> > dir_class[], write_class[], read_class[], chattr_class[] and signal_class[]
> 
> Groan, it can be replaced by local variables, but it does not result
> in the same functionality.
> 
> These audit classes are arrays of syscall numbers, which are different
> for 32 and 64 bit. ia32/audit.c includes unistd_32.h not unistd.h for
> exactly this reason.
> 

Thanks, got it :-)

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/