lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 May 2009 18:34:31 -0700 From: Yinghai Lu <yinghai@...nel.org> To: Jack Steiner <steiner@....com>, "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>, Andrew Morton <akpm@...ux-foundation.org> CC: David Rientjes <rientjes@...gle.com>, Andi Kleen <andi@...stfloor.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Rusty Russell <rusty@...tcorp.com.au>, Mike Travis <travis@....com> Subject: [PATCH] x86: fix system without memory on node0 Jack found that crash with doesn't have memory on node0. it turns out with per_cpu changeset, node_number for BSP will be alway 0, and it is consistent to cpu_to_node() that is to near node already. aka when numa_set_node() for node0 is called early before per_cpu area is setup try to set the node_number for boot cpu, after we get per_cpu area setup. [ Impact: fix crashing on memoryless node 0] Reported-by: Jack Steiner <steiner@....com> Signed-off-by: Yinghai Lu <yinghai@...nel.org> --- arch/x86/kernel/setup_percpu.c | 8 ++++++++ 1 file changed, 8 insertions(+) Index: linux-2.6/arch/x86/kernel/setup_percpu.c =================================================================== --- linux-2.6.orig/arch/x86/kernel/setup_percpu.c +++ linux-2.6/arch/x86/kernel/setup_percpu.c @@ -423,6 +423,14 @@ void __init setup_per_cpu_areas(void) early_per_cpu_ptr(x86_cpu_to_node_map) = NULL; #endif +#if defined(CONFIG_X86_64) && defined(CONFIG_NUMA) + /* + * make sure boot cpu node_number is right, when boot cpu is on the + * node that doesn't have mem installed + */ + per_cpu(node_number, boot_cpu_id) = cpu_to_node(boot_cpu_id); +#endif + /* Setup node to cpumask map */ setup_node_to_cpumask_map(); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists