linux-kernel - Re: [PATCH 001/001] leds: alix-leds2 fixed for Award BIOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090513151415.6e84fd82.akpm@linux-foundation.org>
Date:	Wed, 13 May 2009 15:14:15 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Tobias_Mueller@...m.info
Cc:	linux-kernel@...r.kernel.org, Richard Purdie <rpurdie@...ys.net>,
	Constantin Baranov <const@...as.ru>
Subject: Re: [PATCH 001/001] leds: alix-leds2 fixed for Award BIOS

On Wed, 13 May 2009 16:10:27 +0200
Tobias M__ller <Tobias_Mueller@...m.info> wrote:

> From: Tobias Mueller <Tobias_Mueller@...m.info>
> 
> Added initialisation of GPIO ports for compatibility with boards with Award
> BIOS (e.g. ALIX.3D3).
> Signed-off-by: Tobias Mueller <Tobias_Mueller@...m.info>
> ---
> diff --git a/drivers/leds/leds-alix2.c b/drivers/leds/leds-alix2.c
> index ddbd773..bda9403 100644
> --- a/drivers/leds/leds-alix2.c
> +++ b/drivers/leds/leds-alix2.c
> @@ -14,7 +14,7 @@
> 
>  static int force = 0;
>  module_param(force, bool, 0444);
> -MODULE_PARM_DESC(force, "Assume system has ALIX.2 style LEDs");
> +MODULE_PARM_DESC(force, "Assume system has ALIX.2/ALIX.3 style LEDs");
> 
>  struct alix_led {
>  	struct led_classdev cdev;
> @@ -155,6 +155,11 @@ static int __init alix_led_init(void)
>  		goto out;
>  	}
> 
> +	/* enable output on GPIO for LED 1,2,3 */
> +	outl(1 << 6, 0x6104);
> +	outl(1 << 9, 0x6184);
> +	outl(1 << 11, 0x6184);
> +
>  	pdev = platform_device_register_simple(KBUILD_MODNAME, -1, NULL, 0);
>  	if (!IS_ERR(pdev)) {
>  		ret = platform_driver_probe(&alix_led_driver, alix_led_probe);

Will this cause problems on boards which are _not_ running that BIOS?

IOW, is this change backward-compatible?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/