[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <1242294664.6642.1000.camel@laptop>
Date: Thu, 14 May 2009 11:51:04 +0200
From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
To: Paul Mackerras <paulus@...ba.org>
Cc: Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 2/3] perf_counter: allow arch to supply event misc
flags and instruction pointer
On Thu, 2009-05-14 at 19:47 +1000, Paul Mackerras wrote:
> Peter Zijlstra writes:
>
> > On Thu, 2009-05-14 at 13:29 +1000, Paul Mackerras wrote:
>
> > > #define PERF_EVENT_MISC_KERNEL (1 << 0)
> > > #define PERF_EVENT_MISC_USER (1 << 1)
> > > #define PERF_EVENT_MISC_OVERFLOW (1 << 2)
> > > +#define PERF_EVENT_MISC_HYPERVISOR (1 << 3)
> >
> > Ah, I think I've taught userspace that either !USER && !KERNEL or USER
> > && KERNEL is HV information, since neither really makes sense :-)
>
> OK, should we do something like this?
>
> #define PERF_EVENT_MISC_CPUMODE_MASK (3 << 0)
> #define PERF_EVENT_MISC_CPUMODE_UNKNOWN (0 << 0)
> #define PERF_EVENT_MISC_USER (1 << 0)
> #define PERF_EVENT_MISC_KERNEL (2 << 0)
> #define PERF_EVENT_MISC_HYPERVISOR (3 << 0)
Yep, that reads nicer :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists