linux-kernel - Re: [PATCH] gs: missing parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A0BF190.7030800@einfochips.com>
Date:	Thu, 14 May 2009 15:55:20 +0530
From:	Viral Mehta <viral.mehta@...fochips.com>
To:	Roel Kluin <roel.kluin@...il.com>
CC:	alan@...hat.com, lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] gs: missing parentheses



Roel Kluin wrote:
> `|' has a higher precedence than `?' so add parentheses.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/drivers/char/sx.c b/drivers/char/sx.c
> index 518f2a2..1f63add 100644
> --- a/drivers/char/sx.c
> +++ b/drivers/char/sx.c
> @@ -979,8 +979,8 @@ static int sx_set_real_termios(void *ptr)
>  			(I_IXANY(port->gs.port.tty) ? SP_TANY : 0) | SP_DCEN);
>  
>  	sx_write_channel_byte(port, hi_break,
> -			(I_IGNBRK(port->gs.port.tty) ? BR_IGN : 0 |
> -			I_BRKINT(port->gs.port.tty) ? BR_INT : 0));
>   
This looks correct to me.
> +			(I_IGNBRK(port->gs.port.tty) ? BR_IGN : 0) |
> +			(I_BRKINT(port->gs.port.tty) ? BR_INT : 0));
>   
It may not want Interrupt and Ignore both at the same time on received 
breaks.

>  
>  	sx_write_channel_byte(port, hi_txon, START_CHAR(port->gs.port.tty));
>  	sx_write_channel_byte(port, hi_rxon, START_CHAR(port->gs.port.tty));
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>
> Email Scanned for Virus & Dangerous Content by : www.CleanMailGateway.com
>
>
>   
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/