linux-kernel - Re: [PATCH 3/7] ide: merge ide_disk_special() into do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A0C0D44.9020308@ru.mvista.com>
Date:	Thu, 14 May 2009 16:23:32 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	Joe Perches <joe@...ches.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] ide: merge ide_disk_special() into do_special()

Hello.

Joe Perches wrote:

>>While at it:
>>- change debug printk() level to KERN_DEBUG
>>- update documentation

>>There should be no functional changes caused by this patch.

>>Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
>>---
>> drivers/ide/ide-io.c |   44 ++++++++++++++++++--------------------------
>> 1 file changed, 18 insertions(+), 26 deletions(-)

>>Index: b/drivers/ide/ide-io.c
>>===================================================================
>>--- a/drivers/ide/ide-io.c
>>+++ b/drivers/ide/ide-io.c
>>@@ -184,11 +184,28 @@ static void ide_tf_set_setmult_cmd(ide_d

> []

>>+#ifdef DEBUG
>>+	printk(KERN_DEBUG "%s: %s: 0x%02x\n", drive->name, s->all);
>>+#endif

> pr_debug?

    Yes, and the number of arguments doesn't correspond to the number of the 
format specifiers.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/