lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20090514134730.GM9835@amd.com>
Date:	Thu, 14 May 2009 15:47:30 +0200
From:	"Roedel, Joerg" <Joerg.Roedel@....com>
To:	Neil Turton <nturton@...arflare.com>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	iommu@...ts.linux-foundation.org
Subject: Re: [PATCH] Fixed the handling of device aliases in the AMD IOMMU
	driver.

On Thu, May 14, 2009 at 02:08:11PM +0100, Neil Turton wrote:
> The devid parameter to set_dev_entry_from_acpi is the requester ID
> rather than the device ID since it is used to index the IOMMU device
> table.  The handling of IVHD_DEV_ALIAS used to pass the device ID.
> This patch fixes it to pass the requester ID.
> 
> Signed-off-by: Neil Turton <nturton@...arflare.com>
> ---
>  arch/x86/kernel/amd_iommu_init.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/amd_iommu_init.c b/arch/x86/kernel/amd_iommu_init.c
> index 61479ba..c013906 100644
> --- a/arch/x86/kernel/amd_iommu_init.c
> +++ b/arch/x86/kernel/amd_iommu_init.c
> @@ -618,7 +618,7 @@ static void __init init_iommu_from_acpi(struct amd_iommu *iommu,
>  		case IVHD_DEV_ALIAS:
>  			devid = e->devid;
>  			devid_to = e->ext >> 8;
> -			set_dev_entry_from_acpi(iommu, devid, e->flags, 0);
> +			set_dev_entry_from_acpi(iommu, devid_to, e->flags, 0);
>  			amd_iommu_alias_table[devid] = devid_to;
>  			break;
>  		case IVHD_DEV_ALIAS_RANGE:

Applied too, thanks.

-- 
           | Advanced Micro Devices GmbH
 Operating | Karl-Hammerschmidt-Str. 34, 85609 Dornach bei München
 System    | 
 Research  | Geschäftsführer: Thomas M. McCoy, Giuliano Meroni
 Center    | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
           | Registergericht München, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ