linux-kernel - Re: [PATCH] x86: Extend test_and_set_bit() test_and_clean_bit() to 64 bits in X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090514141649.GD10933@one.firstfloor.org>
Date:	Thu, 14 May 2009 16:16:49 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Sheng Yang <sheng@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-mm <linux-mm@...ck.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] x86: Extend test_and_set_bit() test_and_clean_bit() to 64 bits in X86_64

On Thu, May 14, 2009 at 07:09:47AM -0700, H. Peter Anvin wrote:
> Andi Kleen wrote:
> >> Well, I just think lots of "#ifdef/#else" is a little annoying here, then use 
> >> REX...
> > 
> > Better add a 'q' string concatination then. The problem with rex is that most 
> > people can't read it even if they know assembler --  they don't know
> > all the details of instruction encoding.
> > 
> 
> The right way to do it is to pass the proper type of register.

For the input index register you don't actually need 64bit and for the
value it's typically memory anyways.


-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/