linux-kernel - Re: Next May 13:[drivers/base/firmware*] Bug while booting on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1242316467.3393.14.camel@macbook.infradead.org>
Date:	Thu, 14 May 2009 16:54:27 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Sachin Sant <sachinp@...ibm.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org
Subject: Re: Next May 13:[drivers/base/firmware*] Bug while booting on x86

On Wed, 2009-05-13 at 18:36 +0530, Sachin Sant wrote:
> BUG: unable to handle kernel NULL pointer dereference at 0000050c
> IP: [<c0119c5d>] kunmap+0x33/0x59

Oops. Does this fix it?

--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -328,7 +328,7 @@ firmware_data_write(struct kobject *kobj, struct
bin_attribute *bin_attr,
 
 		memcpy(page_data + page_ofs, buffer, page_cnt);
 
-		kunmap(page_data);
+		kunmap(fw_priv->pages[page_nr]);
 		buffer += page_cnt;
 		offset += page_cnt;
 		count -= page_cnt;

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/