linux-kernel - Re: [PATCH 6/7] ide: pass number of ports to ide_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200905142151.15854.bzolnier@gmail.com>
Date:	Thu, 14 May 2009 21:51:15 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] ide: pass number of ports to ide_host_{alloc,add}()

On Thursday 14 May 2009 20:59:51 Sergei Shtylyov wrote:

> > @@ -467,7 +467,7 @@ icside_register_v6(struct icside_state *
> >  	struct ide_host *host;
> >  	unsigned int sel = 0;
> >  	int ret;
> > -	hw_regs_t hw[2], *hws[] = { &hw[0], NULL, NULL, NULL };
> > +	hw_regs_t hw[2], *hws[] = { &hw[0], NULL };
> 
>     I wonder if there's an old bug here since I'm not seeing when hws[1] is 
> set to non-NULL -- despite there are apparently two ports?
> 
>     Indeed, this bug seems to date back to the 'struct ide_host' 
> introduction, see this:
>  
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=48c3c1072651922ed153bcf0a33ea82cf20df390#patch1...

Care to send a fix?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/