linux-kernel - Re: [PATCH] ACPI: do not mark TSC unstable for invalid C-states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0905142217340.3561@localhost.localdomain>
Date:	Thu, 14 May 2009 22:19:51 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Len Brown <lenb@...nel.org>
cc:	Janne Kulmala <janne.t.kulmala@....fi>,
	Frans Pop <elendil@...net.nl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...e.hu>, johnstul@...ibm.com
Subject: Re: [PATCH] ACPI: do not mark TSC unstable for invalid C-states

On Thu, 14 May 2009, Len Brown wrote:

> hang on, that patch will fail for the case where valid
> is (about to be) set to 1 and we'll fail to disable the TSC
> for systems which _do_ have c3.  I'll send an updated patch shortly.

Yep, you are right. I missed the cx->valid update in
apic_processor_power_verify_cX(). So my patch would break the laptops
instead of breaking desktops and servers :)

Moving it to acpi_timer_check_state() is the best we can do and that
saves us ifdeffery as well as acpi_timer_check_state() is already x86
only.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/