linux-kernel - [PATCH 2/3] perf_counter: allow arch to supply event misc flags and instruction pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <18955.36913.304477.712583@drongo.ozlabs.ibm.com>
Date:	Thu, 14 May 2009 13:29:53 +1000
From:	Paul Mackerras <paulus@...ba.org>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: [PATCH 2/3] perf_counter: allow arch to supply event misc flags and instruction pointer

At present the values we put in overflow events for the misc flags
indicating processor mode and the instruction pointer are obtained
using the standard user_mode() and instruction_pointer() functions.
Those functions tell you where the performance monitor interrupt
was taken, which might not be exactly where the counter overflow
occurred, for example because interrupts were disabled at the point
where the overflow occurred, or because the processor had many
instructions in flight and chose to complete some more instructions
beyond the one that caused the counter overflow.

Some architectures (e.g. powerpc) can supply more precise information
about where the counter overflow occurred and the processor mode at
that point.  This introduces new functions, perf_misc_flags() and
perf_instruction_pointer(), which arch code can override to provide
more precise information if available.  They have default implementations
which are identical to the existing code.

This also adds a new misc flag value, PERF_EVENT_MISC_HYPERVISOR, for
the case where a counter overflow occurred in the hypervisor.

Signed-off-by: Paul Mackerras <paulus@...ba.org>
---
 include/linux/perf_counter.h |    7 +++++++
 kernel/perf_counter.c        |    5 ++---
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h
index 614f921..2b12d98 100644
--- a/include/linux/perf_counter.h
+++ b/include/linux/perf_counter.h
@@ -213,6 +213,7 @@ struct perf_counter_mmap_page {
 #define PERF_EVENT_MISC_KERNEL		(1 << 0)
 #define PERF_EVENT_MISC_USER		(1 << 1)
 #define PERF_EVENT_MISC_OVERFLOW	(1 << 2)
+#define PERF_EVENT_MISC_HYPERVISOR	(1 << 3)

 struct perf_event_header {
 	__u32	type;
@@ -588,6 +589,12 @@ extern int sysctl_perf_counter_mlock;

 extern void perf_counter_init(void);

+#ifndef perf_misc_flags
+#define perf_misc_flags(regs)	(user_mode(regs) ? PERF_EVENT_MISC_USER : \
+				 PERF_EVENT_MISC_KERNEL)
+#define perf_instruction_pointer(regs)	instruction_pointer(regs)
+#endif
+
 #else
 static inline void
 perf_counter_task_sched_in(struct task_struct *task, int cpu)		{ }
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index ff166c1..89568de 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -1978,11 +1978,10 @@ static void perf_counter_output(struct perf_counter *counter,
 	header.size = sizeof(header);

 	header.misc = PERF_EVENT_MISC_OVERFLOW;
-	header.misc |= user_mode(regs) ?
-		PERF_EVENT_MISC_USER : PERF_EVENT_MISC_KERNEL;
+	header.misc |= perf_misc_flags(regs);

 	if (record_type & PERF_RECORD_IP) {
-		ip = instruction_pointer(regs);
+		ip = perf_instruction_pointer(regs);
 		header.type |= PERF_RECORD_IP;
 		header.size += sizeof(ip);
 	}
-- 
1.5.5.rc3.7.gba13

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/