linux-kernel - Re: [PATCH 4/5] x86: implement percpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A0D357A.1070705@kernel.org>
Date:	Fri, 15 May 2009 18:27:22 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Jan Beulich <JBeulich@...ell.com>
CC:	mingo@...e.hu, andi@...stfloor.org, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, hpa@...or.com
Subject: Re: [PATCH 4/5] x86: implement percpu_alloc kernel parameter

Jan Beulich wrote:
>>>> Tejun Heo <tj@...nel.org> 15.05.09 06:28 >>>
>> @@ -395,6 +404,16 @@ out_free_ar:
>> 	return ret;
>> }
>>
>> +/* for explicit first chunk allocator selection */
>> +static char pcpu_chosen_alloc[16] __initdata;
>> +
>> +static int __init percpu_alloc_setup(char *str)
>> +{
>> +	strncpy(pcpu_chosen_alloc, str, sizeof(pcpu_chosen_alloc) - 1);
>> +	return 0;
>> +}
>> +early_param("percpu_alloc", percpu_alloc_setup);
>> +
>> static inline void setup_percpu_segment(int cpu)
>> {
>> #ifdef CONFIG_X86_32
> 
> Does this really need to be early_param()? setup_per_cpu_areas()
> runs after setup_arch(), which is where the full command line
> parsing happens.

__setup() callbacks ran after PERCPU allocation.  Confirmed with
printk.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/