linux-kernel - Re: [patch 29/51] mac80211: pid, fix memory corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090515144901.GB27812@suse.de>
Date:	Fri, 15 May 2009 07:49:01 -0700
From:	Greg KH <gregkh@...e.de>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org,
	Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>, Willy Tarreau <w@....eu>,
	Rodrigo Rubira Branco <rbranco@...checkpoint.com>,
	Jake Edge <jake@....net>, Eugene Teo <eteo@...hat.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [patch 29/51] mac80211: pid, fix memory corruption

On Fri, May 15, 2009 at 08:23:50AM +0200, Jiri Slaby wrote:
> Hi,
> 
> note that you were about to drop this one now because of waiting for a
> fixup which is not upstream so far. Did anything change?

Hm, no, I dropped a different patch,
	mac80211-minstrel-fix-memory-corruption.patch
did I drop the wrong one?


Should I bring that one back and drop the one below?

confused,

greg k-h

> (This is the one which fixes a memory corruption, but triggers a bug
> causing oopses on single band cards.)
> 
> On 05/15/2009 12:33 AM, Greg KH wrote:
> From: Jiri Slaby <jirislaby@...il.com>
> 
> commit 6909268dc93ae4b0b8e1ebb4b2fa70b1a47dd347 upstream.
> 
> pid doesn't count with some band having more bitrates than the one
> associated the first time.
> Fix that by counting the maximal available bitrate count and allocate
> big enough space.
> 
> Secondly, fix touching uninitialized memory which causes panics.
> Index sucked from this random memory points to the hell.
> The fix is to sort the rates on each band change.
> 
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
> Signed-off-by: John W. Linville <linville@...driver.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/