linux-kernel - Re: [PATCH 1/3] Introduce "struct wait_info" to simplify wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090515173720.GB29647@elte.hu>
Date:	Fri, 15 May 2009 19:37:20 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Vitaly Mayatskikh <v.mayatskih@...il.com>
Cc:	Roland McGrath <roland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Introduce "struct wait_info" to simplify
	wait_task*() pathes


* Vitaly Mayatskikh <v.mayatskih@...il.com> wrote:

> At Wed, 13 May 2009 11:13:58 -0700 (PDT), Roland McGrath wrote:
> 
> > What's the benefit of this?  Those parameters are probably 
> > happily in registers and compiled well, I would guess.  Adding 
> > more memory copying does not seem like a benefit.  Have you 
> > verified that your change reduces code size or something like 
> > that?
> 
> Yeah, I was wrong. There's no benefit in size of .text

but there's a lot of benefit in cleanliness - just look at the 
simplification of the prototypes.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/