linux-kernel - Re: [PATCH 09/11] drivers/scsi: Convert #ifdef DEBUG printk(KERN_DEBUG to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1242414292.3373.6.camel@Joe-Laptop.home>
Date:	Fri, 15 May 2009 12:04:52 -0700
From:	Joe Perches <joe@...ches.com>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH 09/11] drivers/scsi: Convert #ifdef DEBUG
 printk(KERN_DEBUG to pr_debug(

On Fri, 2009-05-15 at 18:56 +0000, James Bottomley wrote:
> On Fri, 2009-05-15 at 10:59 -0700, Joe Perches wrote:
> > diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
> > index 8059494..29d5118 100644
> > --- a/drivers/scsi/aha1542.c
> > +++ b/drivers/scsi/aha1542.c
> > @@ -509,9 +509,7 @@ static void aha1542_intr_handle(struct Scsi_Host *shost)
> >  		if (mbistatus == 3)
> >  			continue;	/* Aborted command not found */
> >  
> > -#ifdef DEBUG
> > -		printk(KERN_DEBUG "...done %d %d\n", mbo, mbi);
> > -#endif
> > +		pr_debug("...done %d %d\n", mbo, mbi);
> 
> This one looks dangerous ... that's a per trigger printk from interrupt
> context.  That's a lot of stuff to bung in the log buffer for a normal
> operating case (which is pretty interrupt heavy).  What does this do to
> system responsiveness?

The normal operating case is not to define DEBUG.

Hmm, if CONFIG_DYNAMIC_DEBUG is enabled, it is a functional change.
Maybe the changes should be to pr_devel?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/