linux-kernel - Re: [PATCH 23/30] loongson: CS5536 MFGPT as system clock source support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1242436541.10164.194.camel@falcon>
Date:	Sat, 16 May 2009 09:15:41 +0800
From:	Wu Zhangjin <wuzhangjin@...il.com>
To:	john stultz <johnstul@...ibm.com>
Cc:	linux-mips@...ux-mips.org, Ralf Baechle <ralf@...ux-mips.org>,
	linux-kernel@...r.kernel.org, Arnaud Patard <apatard@...driva.com>,
	loongson-dev@...glegroups.com, zhangfx@...ote.com, yanh@...ote.com,
	Philippe Vachon <philippe@...pig.ca>,
	Zhang Le <r0bertz@...too.org>, Erwan Lerale <erwan@...scow.com>
Subject: Re: [PATCH 23/30] loongson: CS5536 MFGPT as system clock source 
 support

On Fri, 2009-05-15 at 17:39 -0700, john stultz wrote:
> On Fri, May 15, 2009 at 3:23 PM, Wu Zhangjin <wuzhangjin@...il.com> wrote:
> > +static struct clocksource clocksource_mfgpt = {
> > +    .name = "mfgpt",
> > +    .rating = 1200,
> 
> Minor nit. Please read the comment over the struct clocksource
> definition in include/linux/clocksource.h for a guide to setting the
> rating value for your clocksource.
> 

as the comment describes, just like the 8253 Timer, the precision of
cs5536 mfgpt Timer is not good, the rating of it should be in the range
of 100-199? Functional for real use, but not desired?

thanks!
Wu Zhangjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/