linux-kernel - RE: [PATCH] ACPI: resume: re-enable SCI-enable workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.00.0905160137210.4571@localhost.localdomain>
Date:	Sat, 16 May 2009 01:49:30 -0400 (EDT)
From:	Len Brown <lenb@...nel.org>
To:	"Moore, Robert" <robert.moore@...el.com>
Cc:	Bob Copeland <me@...copeland.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"Lin, Ming M" <ming.m.lin@...el.com>,
	Bjorn Helgaas <bjorn.helgaas@...com>,
	"Zhao, Yakui" <yakui.zhao@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: RE: [PATCH] ACPI: resume: re-enable SCI-enable workaround


> >The BIOS bug workaround mistakenly got disabled
> >when we followed the ACPI specification more closely
> >by ignoring OS updates to that bit.
> 
> Not exactly. ACPICA has always preserved the SCI_EN bit. Linux apparently has a "linux-only" patch to ACPICA that disables this.
> 
> The recent version of ACPICA change the #define enough such that the patch no longer works.

"We" here means Linux, and thus the description is accurate.

The fact is that in 2.6.29 Linux had
ACPI_PM1_CONTROL_PRESERVED_BITS 0x0200
and when "we" updated it to 0x201 via the ACPICA update,
the workaround in the Linux resume code became a NOP.

-Len
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/