[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090516092645.GA11652@localhost>
Date: Sat, 16 May 2009 17:26:45 +0800
From: Wu Fengguang <fengguang.wu@...el.com>
To: Rik van Riel <riel@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
"hannes@...xchg.org" <hannes@...xchg.org>,
"peterz@...radead.org" <peterz@...radead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"tytso@....edu" <tytso@....edu>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"elladan@...imo.com" <elladan@...imo.com>,
"npiggin@...e.de" <npiggin@...e.de>,
"cl@...ux-foundation.org" <cl@...ux-foundation.org>,
"kosaki.motohiro@...fujitsu.com" <kosaki.motohiro@...fujitsu.com>,
"minchan.kim@...il.com" <minchan.kim@...il.com>
Subject: Re: [PATCH -mm] vmscan: make mapped executable pages the first
class citizen
On Tue, May 12, 2009 at 09:20:11PM +0800, Rik van Riel wrote:
> Wu Fengguang wrote:
>
> >> Also, the change makes this comment:
> >>
> >> spin_lock_irq(&zone->lru_lock);
> >> /*
> >> * Count referenced pages from currently used mappings as
> >> * rotated, even though they are moved to the inactive list.
> >> * This helps balance scan pressure between file and anonymous
> >> * pages in get_scan_ratio.
> >> */
> >> reclaim_stat->recent_rotated[!!file] += pgmoved;
> >>
> >> inaccurate.
> >
> > Good catch, I'll just remove the stale "even though they are moved to
> > the inactive list".
>
> Well, it is still true for !VM_EXEC pages.
This comment?
Count referenced pages from currently used mappings as rotated, even
though only some of them are actually re-activated. This helps...
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists