linux-kernel - Re: [PATCH] hwmon: (lm78) add missing __devexit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 16 May 2009 12:02:29 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] hwmon: (lm78) add missing __devexit_p()

Hi Mike,

On Fri, 15 May 2009 14:50:23 -0400, Mike Frysinger wrote:
> The remove function uses __devexit, so the .remove assignment needs
> __devexit_p() to fix a build error with hotplug disabled.
> 
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> CC: Jean Delvare <khali@...ux-fr.org>
> ---
>  drivers/hwmon/lm78.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/lm78.c b/drivers/hwmon/lm78.c
> index b5e3b28..a1787fd 100644
> --- a/drivers/hwmon/lm78.c
> +++ b/drivers/hwmon/lm78.c
> @@ -182,7 +182,7 @@ static struct platform_driver lm78_isa_driver = {
>  		.name	= "lm78",
>  	},
>  	.probe		= lm78_isa_probe,
> -	.remove		= lm78_isa_remove,
> +	.remove		= __devexit_p(lm78_isa_remove),
>  };
>  
>  

Good catch. Applied, thanks!

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/