linux-kernel - Re: [PATCH 3/10 -tip] x86: Add cpufeatures for Advanced Power Management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0905171415150.3516@localhost.localdomain>
Date:	Sun, 17 May 2009 14:17:00 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
cc:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...nel.org>,
	Robert Richter <robert.richter@....com>,
	Dave Jones <davej@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	x86 maintainers <x86@...nel.org>
Subject: Re: [PATCH 3/10 -tip] x86: Add cpufeatures for Advanced Power
 Management

On Fri, 15 May 2009, Jaswinder Singh Rajput wrote:
> > Do you really believe that open-coding x86_capability[9] in .../common.c
> > is better than the open-coding in ../powernow-k8.c ?
> > 
> 
> BTW, then how you can set x86_capability[9] in one shot ? do you want me
> to set each bit with set_cpu_cap() ?

Using "9" as an array index is the point. This needs to be a constant
near the other constants which describe the bits and a big fat comment.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/