linux-kernel - Re: 2.6.30-rc6: Reported regressions from 2.6.29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac3eb2510905161715m7d42879bqdc0d59c465521e99@mail.gmail.com>
Date:	Sun, 17 May 2009 02:15:20 +0200
From:	Kay Sievers <kay.sievers@...y.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Natalie Protasevich <protasnb@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: 2.6.30-rc6: Reported regressions from 2.6.29

On Sun, May 17, 2009 at 02:01, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:

>        [   10.428691] Error: Driver 'rtc_cmos' is already registered, aborting...
>
> but the driver doesn't really care whether that succeeded or not, but then
> the platform_driver_probe fails (because the thing is already in use), so
> then it ends up unregistering something that never got registered in the
> first place.
>
> I think this is strictly speaking a bug in driver_unregister(), which is
> too fragile. If you unregister a drivert that wasn't registered, we
> shouldn't oops.
>
> But we could certainly do it at the rtc-cmos.c level too, and just not
> unregister it if the registration failed. My gut feel is that we should
> aim for the core driver helpers to be less fragile, though - we'll always
> have driver bugs.

In:
 driver_remove_file()
we try to access the private part:
 sysfs_remove_file(&drv->p->kobj, ...
and that is NULL, for an unregistered driver, I would expect.

I'm looking into it.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/