linux-kernel - Re: [PATCH] gpio: max7301: add missing _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200905181048.24264.jbe@pengutronix.de>
Date:	Mon, 18 May 2009 10:48:23 +0200
From:	Juergen Beisert <jbe@...gutronix.de>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org,
	Dmitry Baryshkov <dbaryshkov@...il.com>
Subject: Re: [PATCH] gpio: max7301: add missing __devexit marking

On Montag, 18. Mai 2009, Mike Frysinger wrote:
> The remove member of the spi_driver max7301_driver uses __devexit_p(),
> so the remove function itself should be marked with __devexit.  Even
> more so considering the probe function is marked with __devinit.
>
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> CC: Juergen Beisert <j.beisert@...gutronix.de>
> CC: Dmitry Baryshkov <dbaryshkov@...il.com>
> ---
>  drivers/gpio/max7301.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/max7301.c b/drivers/gpio/max7301.c
> index 3e7f4e0..7b82eaa 100644
> --- a/drivers/gpio/max7301.c
> +++ b/drivers/gpio/max7301.c
> @@ -287,7 +287,7 @@ exit_destroy:
>  	return ret;
>  }
>
> -static int max7301_remove(struct spi_device *spi)
> +static int __devexit max7301_remove(struct spi_device *spi)
>  {
>  	struct max7301 *ts;
>  	int ret;

Acked-by: Juergen Beisert <j.beisert@...gutronix.de>

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/