linux-kernel - Re: [PATCH 2/2] driver core:firmware:fix request_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090518131524.6e63f3e6@gondolin>
Date:	Mon, 18 May 2009 13:15:24 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	tom.leiming@...il.com
Cc:	arjan@...radead.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, Ming Lei <tom.leiming@...il.com>
Subject: Re: [PATCH 2/2] driver core:firmware:fix request_firmware_nowait

On Sat, 16 May 2009 21:54:18 +0800,
tom.leiming@...il.com wrote:

> @@ -646,14 +646,12 @@ request_firmware_nowait(
>  		.uevent = uevent,
>  	};
> 
> -	task = kthread_run(request_firmware_work_func, fw_work,
> -			    "firmware/%s", name);
> -
> -	if (IS_ERR(task)) {
> +	ret = async_run_inatomic(request_firmware_work_func, fw_work);
> +	if (ret) {
>  		fw_work->cont(NULL, fw_work->context);
>  		module_put(fw_work->module);
>  		kfree(fw_work);
> -		return PTR_ERR(task);
> +		return ret;

You change the return code from an usual error code to a boolean value
here...

>  	}
>  	return 0;
>  }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/